Specify extra runtime flags in tests, not CI #1497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables keeping runtime/wasmtime flags scoped to just one test rather than requiring it for all tests. For example `-Wcomponent-model-threading` is scoped to just one test right now.
alexcrichton
force-pushed
the
scope-wasmtime-flags
branch
from
c90e837 to
84c1a25
Compare
pchickey
approved these changes
Jan 13, 2026
cpetig
added a commit
to cpetig/wit-bindgen
that referenced
this pull request
Jan 20, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
* more fixed size implementation * more fixed list implementation * test passes with modified wasmtime * document and compare test * returning a fixed size list works * re-enable normal parameters * clean up and use wac fork * another testcase passing * oh, two failing tests * integrate changes from symmetric branch * adapt and simplify C++ example * modernize code * linear code size for fixed size arrays (except when flattened) * fix element offset, missing code for c++, missing testing argument * leverage #1497 (wasmtime flags in test case) * standardize on fixed *length* lists name * another naming correction * standardize on iter_elem variable name * one file was missing in the last commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables keeping runtime/wasmtime flags scoped to just one test rather than requiring it for all tests. For example
-Wcomponent-model-threadingis scoped to just one test right now.