Refactor defining core wasm async functions #12365
Merged
+115
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some preexisting duplication between `Func`-related constructors and `Linker`-related constructors. This consolidates everything into `HostFunc` which duplicates type signatures a bit more but complexity-wise reduces the amount of internal duplication. This additionally notably cuts down on usage of `block_on` literally, if not conceptually, which is going to eventually be important for rationalizing it with `*_concurrent` functions.
dicej
approved these changes
Jan 16, 2026
| ty: FuncType, | ||
| func: impl Fn(Caller<'_, T>, &mut [ValRaw]) -> Result<()> + Send + Sync + 'static, | ||
| ) -> Self { | ||
| assert!(ty.comes_from_same_engine(store.as_context().engine())); |
Contributor
There was a problem hiding this comment.
Why is this (and the other removed comes_from_same_engine assertions) no longer needed?
Member
Author
There was a problem hiding this comment.
Oh still needed, but amongst the layers here this assert was happening at every layer so I deleted all the duplicate ones to delegate to the lowest-level layers to perform the assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some preexisting duplication between
Func-related constructors andLinker-related constructors. This consolidates everything intoHostFuncwhich duplicates type signatures a bit more but complexity-wise reduces the amount of internal duplication.This additionally notably cuts down on usage of
block_onliterally, if not conceptually, which is going to eventually be important for rationalizing it with*_concurrentfunctions.