Restrict bad renamed column name matching to whole word OHLCV names#201
Open
jarodmeng wants to merge 1 commit intobusiness-science:masterfrom
Open
Restrict bad renamed column name matching to whole word OHLCV names#201jarodmeng wants to merge 1 commit intobusiness-science:masterfrom
jarodmeng wants to merge 1 commit intobusiness-science:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a stop gap solution to issue #137 until a more comprehensive solution is implemented. The small change basically restricts the bad name matching to whole-word only rather than the current more liberal partial matching. In this fix, only those column names that match the whole-word OHLCV names will be classified as bad names and replaced.