Update: non-option argument instead of --startup-url#230
Open
farhadmak wants to merge 3 commits intobrowsh-org:masterfrom
Open
Update: non-option argument instead of --startup-url#230farhadmak wants to merge 3 commits intobrowsh-org:masterfrom
farhadmak wants to merge 3 commits intobrowsh-org:masterfrom
Conversation
Member
|
Sorry for the delay. It's been so long since I looked at the code that I can't tell immediately what's going on. Is it easy to add a little test case? Hmm, maybe not, you'd have to do something hacky in this function I think. Anyway, if you think this is good to go, then I'll merge it. |
Contributor
Author
|
I'll look into writing up a test. A few things to note with this code, any argument without a flag will be opened into a new tab. If it is a link, then great, itll open to that link. If not, it does a google search on it. Off the top of your head, does this pose an issue? (i.e another command that has no flag) |
f290601 to
81f41b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request should complete #205 , Main updates:
browsh "browsh documentation"will open a google search of the string.