Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1743 +/- ##
===========================================
- Coverage 25.46% 25.42% -0.04%
===========================================
Files 105 105
Lines 2686 2686
Branches 253 253
===========================================
- Hits 684 683 -1
- Misses 2002 2003 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LizBaldo
approved these changes
Dec 5, 2025
aednichols
approved these changes
Dec 23, 2025
|
Do not merge because: we're still not sure of the path forward for related PR DataBiosphere/leonardo#4889 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leo needs Http4s version 45, and workbench-libs needs to have a compatible version
https://nvd.nist.gov/vuln/detail/CVE-2025-59822
Blaze client is deprecated in favor of ember, so I had to make that switch to update http4s
PR checklist
If you're doing a major or minor version bump to any libraries:
project/Settings.scalacreateVersion()CHANGELOG.mdfor those libraries@deprecatedinstead of deleting code where possibleIn all cases:
README.mdand theCHANGELOG.mdfor any libs you changed withTRAVIS-REPLACE-MEto auto-update the version string