Skip to content

Comments

[CTM-182] Http4s update#1743

Open
lucymcnatt wants to merge 6 commits intodevelopfrom
CTM-182-sec-updates
Open

[CTM-182] Http4s update#1743
lucymcnatt wants to merge 6 commits intodevelopfrom
CTM-182-sec-updates

Conversation

@lucymcnatt
Copy link
Contributor

@lucymcnatt lucymcnatt commented Dec 1, 2025

Leo needs Http4s version 45, and workbench-libs needs to have a compatible version
https://nvd.nist.gov/vuln/detail/CVE-2025-59822

Blaze client is deprecated in favor of ember, so I had to make that switch to update http4s

PR checklist

  • For each library you've modified here, decide whether it requires a major, minor, or no version bump. (Click here for guidance)

If you're doing a major or minor version bump to any libraries:

  • Bump the version in project/Settings.scala createVersion()
  • Update CHANGELOG.md for those libraries
  • I promise I used @deprecated instead of deleting code where possible

In all cases:

  • Replace the appropriate version hashes in README.md and the CHANGELOG.md for any libs you changed with TRAVIS-REPLACE-ME to auto-update the version string
  • Get two thumbsworth of PR review
  • Verify all tests go green (CI and coverage tests)
  • Squash commits and merge to develop
  • Delete branch after merge

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.42%. Comparing base (56f2c74) to head (41ed620).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1743      +/-   ##
===========================================
- Coverage    25.46%   25.42%   -0.04%     
===========================================
  Files          105      105              
  Lines         2686     2686              
  Branches       253      253              
===========================================
- Hits           684      683       -1     
- Misses        2002     2003       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aednichols
Copy link

Do not merge because: we're still not sure of the path forward for related PR DataBiosphere/leonardo#4889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants