Skip to content

fix(ui) + enhancement(ui): handle spaced file paths and add more picker support and fallback#314

Merged
brianhuster merged 2 commits intobrianhuster:mainfrom
Ren-B-7:main
Jul 16, 2025
Merged

fix(ui) + enhancement(ui): handle spaced file paths and add more picker support and fallback#314
brianhuster merged 2 commits intobrianhuster:mainfrom
Ren-B-7:main

Conversation

@Ren-B-7
Copy link
Copy Markdown
Contributor

@Ren-B-7 Ren-B-7 commented Jul 16, 2025

Fix: File Path Handling and Picker Integration

Overview

This update addresses multiple improvements and edge cases related to file selection and browser integration.


What was fixed

  • File paths with spaces (e.g. test with space.md) caused issues when opening in browsers like Chromium, which misinterpreted unquoted paths.

    • Resolved by using neovim shell escape vim.fn.shellescape to pass file paths correctly.
  • Missing file or filename edge cases are now handled more safely to prevent runtime errors.

    • Added more checks for nil or empty paths.

Enhancements

  • Extended picker support:

    • Now supports more pickers like snacks.nvim.
    • Falls back gracefully to vim.ui.select when no other picker is available.
  • Improved input validation and fallback logic across picker and file handling layers.


Tested

  • Browsers like Chromium now correctly open files with spaces.
  • Picker fallback logic works with and without third-party UI libraries.
  • Invalid paths are ignored or handled gracefully.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request! We appreciate your contribution. Please ensure that your changes are well documented and tested, and are formatted as noexpandtab.

@brianhuster brianhuster merged commit e327307 into brianhuster:main Jul 16, 2025
4 of 5 checks passed
@brianhuster
Copy link
Copy Markdown
Owner

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants