fix(ui) + enhancement(ui): handle spaced file paths and add more picker support and fallback#314
Merged
brianhuster merged 2 commits intobrianhuster:mainfrom Jul 16, 2025
Ren-B-7:main
Merged
fix(ui) + enhancement(ui): handle spaced file paths and add more picker support and fallback#314brianhuster merged 2 commits intobrianhuster:mainfrom Ren-B-7:main
brianhuster merged 2 commits intobrianhuster:mainfrom
Ren-B-7:main
Conversation
Owner
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: File Path Handling and Picker Integration
Overview
This update addresses multiple improvements and edge cases related to file selection and browser integration.
What was fixed
File paths with spaces (e.g.
test with space.md) caused issues when opening in browsers like Chromium, which misinterpreted unquoted paths.vim.fn.shellescapeto pass file paths correctly.Missing file or filename edge cases are now handled more safely to prevent runtime errors.
nilor empty paths.Enhancements
Extended picker support:
snacks.nvim.vim.ui.selectwhen no other picker is available.Improved input validation and fallback logic across picker and file handling layers.
Tested