Skip to content

[WIP] Allow custom panic messages in assert_* macros#45

Open
adrianwong wants to merge 1 commit intobrendanzab:masterfrom
adrianwong:custom-panic-message
Open

[WIP] Allow custom panic messages in assert_* macros#45
adrianwong wants to merge 1 commit intobrendanzab:masterfrom
adrianwong:custom-panic-message

Conversation

@adrianwong
Copy link
Copy Markdown
Contributor

@adrianwong adrianwong commented Nov 26, 2018

This is an attempt to resolve #44.

@adrianwong adrianwong changed the title [WIP] Accept custom panic messages in assert_* macros [WIP] Allow custom panic messages in assert_* macros Nov 26, 2018
@joshburkart
Copy link
Copy Markdown
Contributor

Would love to get this in, was just looking for this feature! Anything we're waiting on? @brendanzab?

@jonaspleyer
Copy link
Copy Markdown
Collaborator

Hey there, In case you are still interested in working on this feature, I have forked the approx crate under https://crates.io/crates/approxim. I have already included many of the other PRs such as #57, #67, #69, #83, #87, #90, #91, #92. Unfortunately I was not able to easily merge your PR as it has been some time and the macros have changed since then. You are more than welcome to open a new PR over there.
https://github.com/jonaspleyer/approxim

@jonaspleyer
Copy link
Copy Markdown
Collaborator

See also #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding messages to assert_* macros

3 participants