[FOUND-113] (3/5) Add client protocol selector#37
Open
mattwd7 wants to merge 6 commits intoFOUND-113-pr2-socket-bufferfrom
Open
[FOUND-113] (3/5) Add client protocol selector#37mattwd7 wants to merge 6 commits intoFOUND-113-pr2-socket-bufferfrom
mattwd7 wants to merge 6 commits intoFOUND-113-pr2-socket-bufferfrom
Conversation
Document protocol selection, route ring server construction through a protocol class hook, and use the shared protocol sentinel for cache-nil miss handling.
Remove the extra timeout rescue/close path from get_multi_yielder now that timeout cleanup is handled at the socket/protocol layers.
mattwd7
force-pushed
the
FOUND-113-pr2-socket-buffer
branch
from
0ee7537 to
5e9593e
Compare
mattwd7
force-pushed
the
FOUND-113-pr3-client-protocol-selector
branch
from
3b7b5a4 to
e271c2e
Compare
mattwd7
changed the title
mattwd7
changed the title
This reverts commit e271c2e.
pcalcado
approved these changes
Mar 3, 2026
|
|
||
| def protocol_class | ||
| if @options[:protocol] == :meta | ||
| require 'dalli/protocol/meta' |
There was a problem hiding this comment.
does the meta add so much that the require here is necessary instead of just requiring them? This feels very dependent on side-effects, unless it's a needed opitimization and we can't make it more encapsulated we should consider just having it being required
Author
There was a problem hiding this comment.
yea, this was a change made to bring performance of :binary protocol in line with our current implementation
|
|
||
| def protocol_class | ||
| if @options[:protocol] == :meta | ||
| require 'dalli/protocol/meta' |
There was a problem hiding this comment.
does the meta add so much that the require here is necessary instead of just requiring them? This feels very dependent on side-effects, unless it's a needed opitimization and we can't make it more encapsulated we should consider just having it being required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dalli::Clientso server instances are created from a protocol class hook.cache_nilssentinel usage with shared protocol base.Test plan
:protocolis unset