[FOUND-113] (2/5) Add buffered socket read helpers#36
Open
mattwd7 wants to merge 9 commits intoFOUND-113-pr1-protocol-basefrom
Open
[FOUND-113] (2/5) Add buffered socket read helpers#36mattwd7 wants to merge 9 commits intoFOUND-113-pr1-protocol-basefrom
mattwd7 wants to merge 9 commits intoFOUND-113-pr1-protocol-basefrom
Conversation
32d5b15 to
6237cb0
Compare
Introduce `read_line` and `read_from_buffer` so text protocol parsing can safely mix line and body reads without losing over-read bytes.
0ee7537 to
5e9593e
Compare
Test read_line, read_from_buffer, and clear_read_buffer behavior including buffering, retry, timeout, and connection reset paths. Made-with: Cursor
Author
|
Binary protocol responses are length-framed:
Because binary always does fixed-size reads in sequence, it doesn’t need a cross-call spill buffer.
A single socket read can pull more than just the line, so leftover bytes must be kept for the next body read. That’s what |
pcalcado
reviewed
Mar 3, 2026
pcalcado
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_line,read_from_buffer,clear_read_buffer).Test plan