Skip to content

[BD-5773] Fix incorrect in-app message type names in campaign export endpoints#12395

Merged
zairro merged 1 commit intodevelopfrom
BD-5773/fix-in-app-message-type-names
Mar 3, 2026
Merged

[BD-5773] Fix incorrect in-app message type names in campaign export endpoints#12395
zairro merged 1 commit intodevelopfrom
BD-5773/fix-in-app-message-type-names

Conversation

@atom-evens
Copy link
Contributor

@atom-evens atom-evens commented Mar 2, 2026

Summary

A user reported that the documented in-app message type names are incorrect in two campaign export API endpoint pages:

  1. Export Campaign Analytics (/campaigns/data_series): The message types list at the bottom of the page referenced in_app_message, but the multivariate response example directly above it uses trigger_in_app_message. Changed in_app_message to trigger_in_app_message to match the actual API response.

  2. Export Campaign Details (/campaigns/details): The channel field description listed in-app_message (with a hyphen instead of an underscore), which is both inconsistently formatted and incorrect. Changed in-app_message to trigger_in_app_message.

Test plan

  • Verify the Export Campaign Analytics page renders correctly and the message types list now shows trigger_in_app_message.
  • Verify the Export Campaign Details page renders correctly and the channel type list now shows trigger_in_app_message.

Made with Cursor

Fixes #11445

Copilot AI review requested due to automatic review settings March 2, 2026 17:49
@atom-evens atom-evens self-assigned this Mar 2, 2026
@atom-evens atom-evens requested a review from a team March 2, 2026 17:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes documented in-app message type names for campaign export endpoints so they align with the response examples (and expected API values), improving accuracy for API consumers.

Changes:

  • Updates /campaigns/details response field description to use trigger_in_app_message for the channel value list.
  • Updates /campaigns/data_series message type list to use trigger_in_app_message to match the multivariate response example.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
_docs/_api/endpoints/export/campaigns/get_campaign_details.md Adjusts documented channel enum values in the response schema to use trigger_in_app_message.
_docs/_api/endpoints/export/campaigns/get_campaign_analytics.md Updates the “possible message types” list to match the trigger_in_app_message key used in the response example.

…names in campaign export endpoints

Made-with: Cursor
@atom-evens atom-evens requested a review from a team March 3, 2026 21:17
@atom-evens atom-evens added status: done Work is done and ready to be merged. and removed In Review labels Mar 3, 2026
Copy link
Contributor

@zairro zairro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@zairro zairro merged commit 014284b into develop Mar 3, 2026
12 checks passed
@zairro zairro deleted the BD-5773/fix-in-app-message-type-names branch March 3, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixes an issue status: done Work is done and ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BD-5773] Docs say in app message type is in_app_message instead of trigger_in_app_message

4 participants