💥 Do not crash on empty pseudo arguments#30
Merged
bramus merged 4 commits intobramus:mainfrom May 26, 2025
Merged
Conversation
bramus
requested changes
May 26, 2025
Owner
bramus
left a comment
There was a problem hiding this comment.
Some minor code optimization suggestions
bramus
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into
::view-transition-old()in the wild and added some more resilience while I was fixing it. This aligns with previous fixes in #14 and #29.The complete code as I found it: