Add support for sha512, xxhash algorithms, and MD5 for httpchecksums#3637
Add support for sha512, xxhash algorithms, and MD5 for httpchecksums#3637SamRemis wants to merge 5 commits intoboto:developfrom
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3637 +/- ##
===========================================
- Coverage 92.71% 92.62% -0.10%
===========================================
Files 68 68
Lines 15561 15629 +68
===========================================
+ Hits 14428 14476 +48
- Misses 1133 1153 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonathan343
left a comment
There was a problem hiding this comment.
Thanks Sam!
I think these changes look pretty good! I don't have much feedback other than improving the changelog entry description. Happy to approve when that's updated.
One question I do have is: Can you can remind me why we're not switching to the CRT implementation of SHA512 when installed in the customers environment?
Co-authored-by: jonathan343 <43360731+jonathan343@users.noreply.github.com>
As far as I know, it's not currently supported. I'll double check with the CRT team to make sure I'm not missing something prior to merging this PR |
Description of changes:
This PR updates the flexible checksums feature to add support for SHA512, XXHASH64, XXHASH3, XXHASH128 as well as add support for passing MD5 through as a checksum to services where it is supported when pre-calculated by the user.
Included are some small refactorings such as updating some unit tests to use pytest.mark.parametrize to reduce code duplication as well as updating the private
has_checksum_headerfunction to use a newget_checksum_headerand which returns a list of algorithms found in the checksum header.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.