Make Collection Controls Aria Accessible

[lcreid]

Make collection_checkboxes and collection_radio_buttons produce output that's more compliant with https://www.w3.org/WAI/tutorials/forms/grouping/#associating-related-controls-with-wai-aria.

Since the markup changes noticeably, this change is only enabled by setting the configuration option group_around_collections = true:

# config/initializers/bootstrap_form.rb

BootstrapForm.configure do |config|
  config.group_around_collections = true
end

This PR includes changes in the test files:

• Moved the collection_checkboxes and collection_radio_button tests to their own files.
• Test collection_checkboxes and collection_radio_button with the group_around_collections options both true and false.

Eventually, this behaviour should become the default, and later, the old behavour should disappear altogether.

Closes: #763.

[johrstrom]

Hi just want to comment here that I think this is a step in the right direction and to thank you for all the work. Labels for radio buttons are being read now and I believe they fit the WCAG guidelines, though I'm not an expert on the matter.

[pablobm]

Why was this made conditional on Rails.env.development?? I just arrived here while trying to figure out why my form worked differently in production and in development modes 😅

[lcreid]

Why was this made conditional on Rails.env.development?? I just arrived here while trying to figure out why my form worked differently in production and in development modes 😅

First, thanks for your patience while I found some time to reply. I have no idea why I did this, and I normally hate it when I see software that behaves differently in production than it does in development. Let me dig some more and see if I had a reason. Otherwise, I'll fix it.

Thanks for catching this, and my sincere apologies for the confusion!