Add test coverage for WeakGc::new_in constructor#36
Open
mrhapile wants to merge 2 commits intoboa-dev:mainfrom
Open
Add test coverage for WeakGc::new_in constructor#36mrhapile wants to merge 2 commits intoboa-dev:mainfrom
mrhapile wants to merge 2 commits intoboa-dev:mainfrom
Conversation
Signed-off-by: mrhapile <[email protected]>
There was a problem hiding this comment.
Pull request overview
Adds a minimal unit test to exercise WeakGc::new_in so oscars/src/collectors/mark_sweep/pointers/weak.rs is covered by the mark-sweep collector test suite.
Changes:
- Add a new
weak_gc_testsmodule with a test that constructs aWeakGcfrom a strongGc. - Execute
WeakGc::new_inin tests to eliminate previously uncovered lines inweak.rs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
nekevss
requested changes
Mar 6, 2026
Signed-off-by: mrhapile <[email protected]>
Contributor
Author
Contributor
Author
|
@nekevss can u give a quick review : ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds a unit test covering the WeakGc constructor.
Currently, oscars/src/collectors/mark_sweep/pointers/weak.rs has

0% test coverage. The WeakGc::new_in constructor is the only
executable code in the file but is not exercised by existing tests.
This PR introduces a minimal test verifying that a WeakGc can be
created from a strong Gc reference. Running this test executes
all lines inside WeakGc::new_in.
Coverage impact:
Before:
weak.rs → 0%
After:
weak.rs → ~100%
No changes to GC implementation are introduced. This PR only
adds test coverage for existing behavior.