Conversation
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
As this is replacing arena3, can you also remove arena3 at the same time.
oscars/src/alloc/mempool3/alloc.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// SlotPool /// |
There was a problem hiding this comment.
issue: don't use this format for sections.
This will probably break CI on main because triple slash is for documentation. Switch to something like:
// ==== SlotPool ==== //
This may need to be done in a few places
There was a problem hiding this comment.
Fixed it. Since this issue seems to exist in other places across the codebase as well, I think it makes sense to open a separate follow up PR to audit and fix all of those
oscars/src/alloc/mempool3/alloc.rs
Outdated
| ); | ||
|
|
||
| // guess the slot count (ignoring bitmap size), size the bitmap based on that guess | ||
| // (rounded up to 64 bit words), then subtract the bitmap size from the total capacity to get the real slot count |
There was a problem hiding this comment.
I think the biggest issue here for me is referring to things as words. It's overloading the term words here. Can you switch the language to just bits or bytes.
There was a problem hiding this comment.
updated it to bytes and chunks
shruti2522
force-pushed
the
mempool3
branch
3 times, most recently
from
1a5ed92 to
a664c65
Compare
Removed, I could have sworn I already removed it but I guess I missed it 😅 |
2 participants
moved
arena3tomempool3as discussed in PR #15, since the allocator supports individual slot deallocation via a free list and bitmap tracking, which is characteristic of a mempool rather than an arena