fix(gc): saturate non_root_count at NON_ROOTS_MAX instead of panicking#4936
Open
shruti2522 wants to merge 1 commit intoboa-dev:mainfrom
Open
fix(gc): saturate non_root_count at NON_ROOTS_MAX instead of panicking#4936shruti2522 wants to merge 1 commit intoboa-dev:mainfrom
shruti2522 wants to merge 1 commit intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4936 +/- ##
===========================================
+ Coverage 47.24% 57.79% +10.55%
===========================================
Files 476 556 +80
Lines 46892 60926 +14034
===========================================
+ Hits 22154 35213 +13059
- Misses 24738 25713 +975 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Well that would make it so that we underflow after all references get dropped. right? Then we're patching one panic with another one |
Author
oh yes, missed that 😅 let me look into this more carefully |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It changes the following:
saturating at
NON_ROOTS_MAXpins the counter instead of panicking. pinned counter returns true foris_rootedso the object is kept alive rather than freed, a leak is safer than a UAF anyways. The limit ~2^31 heap references to one object is unreachable in practice