feat(engine): add JsUint8Array::to_vec for copying viewed bytes#4932
Open
alienx5499 wants to merge 2 commits intoboa-dev:mainfrom
Open
feat(engine): add JsUint8Array::to_vec for copying viewed bytes#4932alienx5499 wants to merge 2 commits intoboa-dev:mainfrom
alienx5499 wants to merge 2 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
Author
|
Hi @jedel1043, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #4722.
It changes the following:
SliceRef::to_vec()helper to copy buffer data (includingAtomicSlice) intoVec<u8>JsUint8Array::to_vec(&mut Context)to copy the viewed byte range of aJsUint8Arrayinto aVec<u8>uint8_array_to_vec_roundtrip) and a doc example forJsUint8Array::to_vecTesting:
cargo test -p boa_engine(including the new unit test and doctest)