Skip to content

Add MVP of virtual machine tracer#4931

Open
nekevss wants to merge 1 commit intoboa-dev:mainfrom
nekevss:rework-vm-tracing
Open

Add MVP of virtual machine tracer#4931
nekevss wants to merge 1 commit intoboa-dev:mainfrom
nekevss:rework-vm-tracing

Conversation

@nekevss
Copy link
Member

@nekevss nekevss commented Mar 7, 2026

This pull request implements a new VirtualMachineTracer trait that emits VirtualMachineEvents rather than immediately printing the values to stdout.

This should allow better customization of event handling.

@nekevss nekevss requested a review from a team as a code owner March 7, 2026 19:05
@nekevss nekevss force-pushed the rework-vm-tracing branch from 80c0e21 to 2778f0a Compare March 7, 2026 19:14
@nekevss nekevss force-pushed the rework-vm-tracing branch from 2778f0a to 01e41cd Compare March 7, 2026 19:16
@github-actions
Copy link

github-actions bot commented Mar 7, 2026

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 49,687 49,666 -21
Ignored 2,262 2,284 +22
Failed 1,014 1,013 -1
Panics 0 0 0
Conformance 93.81% 93.77% -0.04%

Tested main commit: b3d820369072123ded8defc927405b99b9012648
Tested PR commit: 01e41cd03fa72e78cc7a00ec3bcf4e67e5ca357d
Compare commits: b3d8203...01e41cd

@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

❌ Patch coverage is 3.77358% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.66%. Comparing base (6ddc2b4) to head (01e41cd).
⚠️ Report is 775 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/vm/trace.rs 0.00% 27 Missing ⚠️
core/engine/src/vm/mod.rs 7.69% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4931       +/-   ##
===========================================
+ Coverage   47.24%   57.66%   +10.41%     
===========================================
  Files         476      557       +81     
  Lines       46892    60964    +14072     
===========================================
+ Hits        22154    35152    +12998     
- Misses      24738    25812     +1074     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant