Open
Conversation
This commit addresses a large number of TODO items found throughout the project. Key changes include: - Refactored utility functions in `src/utils/utils.js` (`convertToToggleableObject`, `convertToRegularObject`) to ensure immutability by operating on cloned objects. - Fixed hardcoded labels in `ResumeDrawerItems` components, now using `varNameToString` for dynamic label generation. - Addressed a NODE_ENV workaround in `gatsby-node.js` by commenting it out and improving related comments. - Improved code documentation for URL parsing regex in `src/utils/spreadsheet-parser.js`. - Completed `TemplateSelector` and `LanguageSelector` components by adding missing PropTypes. - Clarified parameter/URI handling and prop passing in `ResumeViewer.jsx` with comments. - Implemented a user alert in `DropZone.jsx` when the file upload limit is exceeded. - Added basic Formik `onSubmit` (logging) and `validate` (name field required) logic in `BuildPage.jsx`. - Removed an unused `baseTheme` object from `src/themes/theme.js`. - Updated `README.MD` with documentation on how to create new resume templates. - Cleaned up and removed obsolete TODO sections from older `README_V1.MD`, `README_V2.MD`, and `README_V3.MD`. - Added client-side validation for Google Spreadsheet URLs in `UploadPage.jsx`, displaying a Snackbar error for invalid formats. - Implemented user-friendly error messages in `ResumeViewer.jsx` for issues during data fetching or processing. - Created `src/utils/utils.test.js` with basic unit tests for key utility functions, covering immutability and core logic. Note: New internationalization keys added for error messages in `DropZone.jsx`, `UploadPage.jsx`, and `ResumeViewer.jsx` could not be added to `src/intl/fr.json` due to a persistent error I encountered. This file will require manual updating for the new keys.
Owner
Author
|
Disclaimer: This PR was implemented by https://jules.google.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses a large number of TODO items found throughout the project.
Key changes include:
src/utils/utils.js(convertToToggleableObject,convertToRegularObject) to ensure immutability by operating on cloned objects.ResumeDrawerItemscomponents, now usingvarNameToStringfor dynamic label generation.gatsby-node.jsby commenting it out and improving related comments.src/utils/spreadsheet-parser.js.TemplateSelectorandLanguageSelectorcomponents by adding missing PropTypes.ResumeViewer.jsxwith comments.DropZone.jsxwhen the file upload limit is exceeded.onSubmit(logging) andvalidate(name field required) logic inBuildPage.jsx.baseThemeobject fromsrc/themes/theme.js.README.MDwith documentation on how to create new resume templates.README_V1.MD,README_V2.MD, andREADME_V3.MD.UploadPage.jsx, displaying a Snackbar error for invalid formats.ResumeViewer.jsxfor issues during data fetching or processing.src/utils/utils.test.jswith basic unit tests for key utility functions, covering immutability and core logic.Note: New internationalization keys added for error messages in
DropZone.jsx,UploadPage.jsx, andResumeViewer.jsxcould not be added tosrc/intl/fr.jsondue to a persistent error I encountered. This file will require manual updating for the new keys.