Conversation
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for partners-bloom-msq2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sites/partners/src/components/settings/MultiselectQuestions/MultiselectQuestionViewDrawer.tsx
Outdated
Show resolved
Hide resolved
emilyjablonski
approved these changes
Apr 8, 2026
Collaborator
emilyjablonski
left a comment
There was a problem hiding this comment.
One small nit, otherwise LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #(6113) #(6143) #(6145) #(6107)
Description
Handles a range of bugs and nice to haves from recent msq bash. Those without tickets can be found here
Preference table
Actioninstead ofActionsfor Preference tableLast updatedon Preference tableTo retirePreference create/edit drawer
Preference view drawer
n/aListing pages
n/alisting preference drawer and listing detail pageRetiredandTo retirepills on listing preference drawer should have same colors as on the Preference tableHow Can This Be Tested/Reviewed?
Run
yarn setup --msqV2Start app
Login to the partners site as an admin
Go to Settings->Preferences
Preference table should default sort on the
LAST UPDATEDcolumn, most right column should beACTION, changing the size of the browser should hit the min width on each column so that the header content is never cut offClick
Add preferenceNo placeholders should appear in any field other than URL
Attempt to have a preference title over 31 characters, on save error should appear and include limit length
Add an option, play with the Opt Out question and confirm Should Collect Address question is hidden when Opt Out is set to Yes
Save with Yes and confirm it stays set
Click
Show to partners, leave all descriptions emptyNew preference should appear at the top of the table
Go to an existing listing or create a new one
On the create/edit page, go to preference section and click
Add preferencesOpen preference drawer and confirm preferences are in alphabetical order
Confirm description sections appear with
n/aAdd new preference
Save changes, confirm description section appear with
n/aReturn to Preference table
Open view drawer for new preference
Confirm description areas have
n/apresentViewbutton for the option should be a darker blueClick
RetirebuttontoRetire status pill should show
To retireReturn to listing and click edit
Open preference drawer and confirm toRetire pill is warning colored and shows
To retireClose listing, msq will retire
Click edit again, open preference drawer and confirm retired pill is warning colored
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: