Skip to content

fix: msq v2 partners bugs#6153

Merged
mcgarrye merged 9 commits intomainfrom
fix/msq-partners-bugs
Apr 8, 2026
Merged

fix: msq v2 partners bugs#6153
mcgarrye merged 9 commits intomainfrom
fix/msq-partners-bugs

Conversation

@mcgarrye
Copy link
Copy Markdown
Collaborator

@mcgarrye mcgarrye commented Apr 8, 2026

This PR addresses #(6113) #(6143) #(6145) #(6107)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Handles a range of bugs and nice to haves from recent msq bash. Those without tickets can be found here
Preference table

  • Action instead of Actions for Preference table
  • Default sort by Last updated on Preference table
  • Preference table should the minimum width of a column to be the width of the column header so that the header content is never cut off
  • toRetire status should appear as To retire

Preference create/edit drawer

  • Opt Out Option question should save and hide Should Collect Address question when true
  • Preference title should have a 31 character limit and error message should reflect it
  • No placeholders should appear other than for URL fields

Preference view drawer

  • Empty description areas should have n/a
  • Incorrect color contract on View button for options on the Preference view drawer

Listing pages

  • Preference drawer on listing create/edit should be alphabetized
  • Empty description areas should have n/a listing preference drawer and listing detail page
  • Retired and To retire pills on listing preference drawer should have same colors as on the Preference table

How Can This Be Tested/Reviewed?

Run yarn setup --msqV2
Start app
Login to the partners site as an admin
Go to Settings->Preferences
Preference table should default sort on the LAST UPDATED column, most right column should be ACTION, changing the size of the browser should hit the min width on each column so that the header content is never cut off
Click Add preference
No placeholders should appear in any field other than URL
Attempt to have a preference title over 31 characters, on save error should appear and include limit length
Add an option, play with the Opt Out question and confirm Should Collect Address question is hidden when Opt Out is set to Yes
Save with Yes and confirm it stays set
Click Show to partners, leave all descriptions empty
New preference should appear at the top of the table

Go to an existing listing or create a new one
On the create/edit page, go to preference section and click Add preferences
Open preference drawer and confirm preferences are in alphabetical order
Confirm description sections appear with n/a
Add new preference
Save changes, confirm description section appear with n/a

Return to Preference table
Open view drawer for new preference
Confirm description areas have n/a present
View button for the option should be a darker blue
Click Retire button
toRetire status pill should show To retire

Return to listing and click edit
Open preference drawer and confirm toRetire pill is warning colored and shows To retire
Close listing, msq will retire
Click edit again, open preference drawer and confirm retired pill is warning colored

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@mcgarrye mcgarrye added the 1 review needed Requires 1 more review before ready to merge label Apr 8, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 8, 2026

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit f292d10
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/69d6a9c1cd725100081b43fb
😎 Deploy Preview https://deploy-preview-6153--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 8, 2026

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit f292d10
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/69d6a9c1b8bbcd0008c9dc61

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 8, 2026

Deploy Preview for partners-bloom-msq2 ready!

Name Link
🔨 Latest commit f292d10
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-msq2/deploys/69d6a9c1b5d8b50008205dc5
😎 Deploy Preview https://deploy-preview-6153--partners-bloom-msq2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 8, 2026

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit f292d10
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/69d6a9c1a899da0008f5957b
😎 Deploy Preview https://deploy-preview-6153--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 8, 2026

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit f292d10
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/69d6a9c131bece00081f4b9c
😎 Deploy Preview https://deploy-preview-6153--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise LGTM!

@emilyjablonski emilyjablonski removed the 1 review needed Requires 1 more review before ready to merge label Apr 8, 2026
@mcgarrye mcgarrye merged commit 08c9eac into main Apr 8, 2026
32 of 33 checks passed
@mcgarrye mcgarrye deleted the fix/msq-partners-bugs branch April 8, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants