You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think i get the main idea here, but want some clarifications regarding the following points:
When the system's creating a segment -> a []byte basically, we use the CountHashWriter to write any data we want into the []byte, before flushing to disk. Is there any reason why we need to manually process each bit of data selectively before writing to []byte? Can we not just interleave the code to encrypt data within the existing code? (within the Write method itself?)
I have added some code that demonstrates optimal callback use (which is more readable as well). Check the code added and let me know if there's a misunderstanding here.
You have mentioned that the reader should be able to discern the WriteToken (counter) itself. I believe this is something that the user should handle. How do you plan on handling overflows with this? If the original Counter overflowed (say) and created a new counter (im not sure if thats the right way to handle this). How will the reader be aware of this fact? (I am assuming that the current system uses exactly one counter from both the writer's and reader's POV makit it easier to synchronize the two.)
Will give another pass when you provide some clarity regarding the aforementioned points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.