MB-66295: Introduce BM25Reader interface #68
Merged
abhinavdangeti merged 2 commits intomasterfrom Apr 16, 2025
Merged
Conversation
Member
Thejas-bhat
commented
Apr 16, 2025
Thejas-bhat
commented
- this is crucial for caching at the snapshot level which can be reused across queries
Thejas-bhat
requested review from
CascadingRadium,
Likith101,
abhinavdangeti and
metonymic-smokey
Thejas-bhat
changed the title
CascadingRadium
approved these changes
Apr 16, 2025
abhinavdangeti
approved these changes
Apr 16, 2025
Member
|
|
abhinavdangeti
added a commit
to blevesearch/bleve
that referenced
this pull request
Apr 16, 2025
- cache a map which maps the field to its cardinality value so that we don't create the fieldDict everytime - Furthermore in the case all the threads have a cache miss, use the write lock to make sure that we create the fieldDict only once to minimize garbage. - Use a separate mutex construct so that the contention is localised to the metrics gathering and doesn't affect the other threads' TFR generation. - blevesearch/bleve_index_api#68 --------- Co-authored-by: Abhinav Dangeti <abhinav@couchbase.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.