MB-66396: Index APIs for TermFrequencies and CentroidCardinalities#2207
Merged
abhinavdangeti merged 13 commits intomasterfrom Nov 7, 2025
Merged
MB-66396: Index APIs for TermFrequencies and CentroidCardinalities#2207abhinavdangeti merged 13 commits intomasterfrom
TermFrequencies and CentroidCardinalities#2207abhinavdangeti merged 13 commits intomasterfrom
Conversation
abhinavdangeti
changed the title
abhinavdangeti
force-pushed
the
mb66396
branch
2 times, most recently
from
87e97aa to
9a7378d
Compare
abhinavdangeti
changed the title
HighestFrequencyTerms and HighestCardinalityCentroids
abhinavdangeti
changed the title
HighestFrequencyTerms and HighestCardinalityCentroidsTermFrequencies and CentroidCardinalities
abhinavdangeti
requested review from
CascadingRadium,
Likith101,
Thejas-bhat,
capemox and
maneuvertomars
capemox
reviewed
Sep 11, 2025
| return nil | ||
| } | ||
|
|
||
| func (i *IndexSnapshot) CentroidCardinalities(field string, limit int, descending bool) ( |
Member
There was a problem hiding this comment.
Because this function is in snapshot_index_vr.go, the method wouldn't be included in IndexSnapshot if the vectors flag is turned off. So it wouldn't be an implementation of IndexInsightsReader anymore. Calls to TermFrequencies in index_impl.go would then fail because the code checks if the interface is implemented for the reader.
Basically, TermFrequencies would only work if it is compiled with vectors, is this intended?
Member
Author
There was a problem hiding this comment.
Ya it was intentional - because the insights project is meant for AI applications which will use this alongside vector data. This is just a start though, hoping to add more functions to the interface.
Member
Author
|
Thanks @CascadingRadium for the review so far, will push up a patch reflecting on your comments soon. |
abhinavdangeti
force-pushed
the
mb66396
branch
from
0be6e44 to
cc615ca
Compare
CascadingRadium
approved these changes
Nov 6, 2025
ns-codereview
pushed a commit
to couchbase/cbft
that referenced
this pull request
Nov 11, 2025
Requires: - blevesearch/faiss#54 - blevesearch/bleve#2207 REST endpoints: - POST /api/index/{indexName}/insights - POST /api/bucket/{bucketName}/scope/{scopeName}/index/{indexName}/insights - RequestBody: `{"field": "<fieldName>", "insight": "termFrequencies", "limit": 5, "descending": false}` `{"field": "<fieldName>", "insight": "centroidCardinalities", "limit": 5, "descending": true}` - Scatter gather request uses RESTful IndexClient(s). Change-Id: Ib9b7782e3fe80f0e6bf93905e5a5f1bb76d8fb71 Reviewed-on: https://review.couchbase.org/c/cbft/+/232479 Tested-by: Abhi Dangeti <abhinav@couchbase.com> Well-Formed: Build Bot <build@couchbase.com> Reviewed-by: Rahul Rampure <rahul.rampure@couchbase.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires:
IndexInsightsReaderbleve_index_api#71