Add support for Puya PY32F071 flash

[Badokas]

Detailed description

Added support for Puya PY32F071 flash.

Your checklist for this pull request

• I've read the Code of Conduct
• I've read the guidelines for contributing to this repository
• It builds for hardware native (see Building the firmware)
• It builds as BMDA (see Building the BMDA)
• I've tested it to the best of my ability
• My commit messages provide a useful short description of what the commits do

Closing issues

--

[Badokas]

@dragonmux any comments on this PR? I see some activity on #2096 and afraid this might be outdated.

[dragonmux]

We'll aim to give it a review in the next couple of days, though it will be targeted to v2.1 when the merge window for that opens as we're in the process of trying to finish stabilising v2.0 for final release.

Please rebase it on main, which will eliminate that merge commit. Wrt #2096, those changes do not obsolete your own and we'll be doing a fixup round once the two PRs can be merged. That PR is focused on reducing repetition in the existing PY32 code specifically.

[dragonmux]

This PR overall looks great - the only real review notes here are about constants that will be undergoing signed-unsigned conversions unnecessarily, and naming constants for improved descriptiveness.

We look forward to getting to merge this in v2.1!

NB: Please review the contribution guidelines and prefix your commit messages accordingly. In this case, they should both have the prefix puya: .

[ALTracer]

There is another big copypaste chunk which is why I submitted #2096. If you don't have a preference which code to copy and adapt, then please consider a for-loop approach. Or I can rebase my PR after your changes get merged and see for myself if I can get size down without being able to test.
Do you have a hyperlink to an English release of PY32F07x Reference Manual which covers PY32F071 and PY32F072? If yes, would you please add both F07x and F00a refmans at the top comment-block of this driver source file?

[Badokas]

There is another big copypaste chunk which is why I submitted #2096. If you don't have a preference which code to copy and adapt, then please consider a for-loop approach. Or I can rebase my PR after your changes get merged and see for myself if I can get size down without being able to test. Do you have a hyperlink to an English release of PY32F07x Reference Manual which covers PY32F071 and PY32F072? If yes, would you please add both F07x and F00a refmans at the top comment-block of this driver source file?

It would be great if you could rebase – I totally agree about duplication, but before your PR I thought this is the way of things in blackmagic-debug. We just needed quickly to support PY32F071 which we use in our project. We've tested on ~5 different boards with this SoC, seems to be working without issues.
I don't have English datasheet, took registers directly from PUYA drivers and IAP demo code (both hosted publicly on GH but don't have precise references rn).

[dragonmux]

Or I can rebase my PR after your changes get merged and see for myself if I can get size down without being able to test.

We are planning, ALTracer, to take this first then yours and then do a fixup of that copy-paste block. This PR as it is stands pretty well on its own within the existing framework, so unless the contributor wishes to work on cleaning that particular part of the contribution up we don't see a reason to block it..

[dragonmux]

Please rebase this on main to get rid of that merge commit, and we'll get this marked approved for the v2.1 cycle.

[dragonmux]

LGTM, we'll merge this once v2.1's merge window opens. When that happens, we'll leave another message on this PR asking it to be rebased just as we go to do the merge itself.

Thank you for the contribution!

[dragonmux]

Please rebase this on main and we'll get it merged now the v2.1 merge window has opened.

[dragonmux]

Unsure how exactly you did the rebase here, but please would you run the following assuming that the remote upstream points to this repo:

git fetch --all --prune
git switch main
git pull upstream
git switch support-py32f017
git rebase -i main
git push -f

[Badokas]

Well, this became outdated due to #2096 so I needed to update my end

[dragonmux]

No worries, we'll re-review when you tell us you're ready then.

[Badokas]

It's ready now.

[dragonmux]

We've got just one note, which once addressed and the branch rebased on main, we'll be happy to approve and merge this PR.

[dragonmux]

LGTM, merging. Thank you for the contribution!