Skip to content

Conversation

@mcamirault
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-30596

📔 Objective

This PR updates several email templates that had hard-coded (and now outdated) years in the copyright notice to use the dynamic CurrentYear property instead. Original ticket was just for the email-protected Send OTP one but we might as well do them all.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mcamirault mcamirault requested review from a team as code owners February 3, 2026 21:14
@mcamirault mcamirault added the ai-review Request a Claude code review label Feb 3, 2026
@claude
Copy link
Contributor

claude bot commented Feb 3, 2026

Claude finished @mcamirault's task in 2m 12s —— View job


Code Review: Approved

PR: PM-30596 Update several email templates to use dynamic year in copyright

Summary

This PR updates 11 email templates to replace hardcoded copyright years with the dynamic {{ CurrentYear }} Handlebars property. The change ensures copyright notices automatically reflect the current year.

Review Details

Category Assessment
Security No concerns
Correctness Verified
Breaking Changes None
Test Coverage N/A (template changes)

Verification Performed

  • Confirmed CurrentYear property is defined in both BaseMailModel and BaseMailView base classes
  • Verified all 11 modified templates inherit from classes that provide CurrentYear:
    • OrganizationConfirmationEnterpriseTeamsView -> BaseMailView
    • OrganizationConfirmationFamilyFreeView -> BaseMailView
    • EmergencyAccessRemoveGranteesMailView -> BaseMailView
    • DefaultEmailOtpViewModel -> BaseMailModel
    • Welcome templates use BaseMailModel / OrganizationWelcomeEmailViewModel
    • Renewal templates -> BaseMailView
  • Confirmed {{ CurrentYear }} format with spaces matches existing patterns in similar templates
  • Verified no remaining hardcoded years in templates after this change

Files Changed

All 11 files contain the same straightforward substitution of 2025 -> {{ CurrentYear }} in the copyright footer.

No issues identified.


Automated code review by Claude

Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving UIF changes

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Logo
Checkmarx One – Scan Summary & Details3c69bca0-cffa-465b-b68e-9bdecf98c184

Great job! No new security vulnerabilities introduced in this pull request

Copy link
Contributor

@ike-kottlowski ike-kottlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.14%. Comparing base (b7923f5) to head (15516dc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6944   +/-   ##
=======================================
  Coverage   56.13%   56.14%           
=======================================
  Files        1974     1974           
  Lines       87195    87195           
  Branches     7762     7762           
=======================================
+ Hits        48948    48952    +4     
+ Misses      36435    36432    -3     
+ Partials     1812     1811    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden removed their request for review February 3, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants