-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(redirect): [PM-30810] Https Redirection for Cloud Users #6852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(redirect): [PM-30810] Https Redirection for Cloud Users #6852
Conversation
…eeplink scheme to duo redirect uri.
…hanges to be able to test locally.
|
New Issues (1)Checkmarx found the following issues in this Pull Request
Fixed Issues (2)Great job! The following issues were fixed in this Pull Request
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6852 +/- ##
==========================================
+ Coverage 56.00% 56.09% +0.08%
==========================================
Files 1965 1968 +3
Lines 86886 86981 +95
Branches 7740 7756 +16
==========================================
+ Hits 48663 48790 +127
+ Misses 36422 36384 -38
- Partials 1801 1807 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… client check to only allow mobile to specify the extra property being sent to the duo api when generating the token.
…ed messaging around how specific clients will build the response as well as added tests.
…flection instead of change the interface.
… local check so the mobile client can govern the scheme used.
…o let the mobie client govern the scheme for redirection.


🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-30810
📔 Objective
Complimentary server work to add the deeplink to the duo generated url.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes