Check if minikube tunnel is running in setup #766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In a minikube environment,
bash scripts/deploy.sh regtest4in wrath-of-nalo depends onminikube tunnelrunning. The same is true forwarnet dashboard.However, unlike
warnet dashboard, scripts/deploy.sh (specifically update_grafana_dashboard.py) does not return a useful error if the ingress IP address was not found. It prints this error instead:and then tries to resolve
Noneas a domain. Compare this to howwarnet dashboardmentions this in that case:I didn't want to duplicate this error handling to update_grafana_dashboard.py. Instead, I thought it'd be nice to let
warnet setupalso handle this, similar to how it's already checking if minikube is running.This is what this PR is doing! The check depends on
pgrepwith the-foption being available.Here's a video of how I tested this:
2026-01-17.13-43-41.mp4
I will include suggestions for my own code in a review. This PR is just meant to show the least invasive change to handle this in
warnet setup, assuming that's even the best place to handle it.