fix(format/html): fix double emitting comments sometimes#8889
Draft
fix(format/html): fix double emitting comments sometimes#8889
Conversation
🦋 Changeset detectedLatest commit: 32da29c The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merging this PR will degrade performance by 7.19%
Performance Changes
Comparing Footnotes
|
62a73c8 to
bf64f5e
Compare
bf64f5e to
32da29c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prettier's parser fundamentally treats comments differently than we do. It treats comments as actual nodes in the markup, but we treat them as trivia. To match this behavior more closely, we try to split children of an element into an iter of
HtmlChildso we can iterate over the children easier.This PR fixes a case where that wasn't happening correctly. Now we prefer the comment we get as an
HtmlChild, and skip formatting it as trivia.Generated by opus 4.5
fixes #8803
Test Plan
Added snapshots.
Docs