Update 3Dtrees: Detailview to v1.1.1#1831
Open
kgerb wants to merge 4 commits intobgruening:masterfrom
Open
Conversation
bgruening
reviewed
Apr 7, 2026
| <token name="@TOOL_VERSION@">1.1.0</token> | ||
| <token name="@VERSION_SUFFIX@">0</token> | ||
| <token name="@TOOL_VERSION@">1.1.1</token> | ||
| <token name="@VERSION_SUFFIX@">1</token> |
Owner
There was a problem hiding this comment.
Suggested change
| <token name="@VERSION_SUFFIX@">1</token> | |
| <token name="@VERSION_SUFFIX@">0</token> |
bgruening
reviewed
Apr 7, 2026
| <requirements> | ||
| <container type="docker">ghcr.io/3dtrees-earth/3dtrees_detailview:@TOOL_VERSION@</container> | ||
| <!-- <container type="docker">ghcr.io/3dtrees-earth/3dtrees_detailview:@TOOL_VERSION@</container> --> | ||
| <container type="docker">docker.io/library/3dtrees-tool-3dtrees_detailview</container> |
bgruening
reviewed
Apr 7, 2026
| <option value="/app/model_europe_v1" selected="true">Europe</option> | ||
| <option value="/app/model_global_v1">Global</option> | ||
| </param> | ||
| <param argument="--output-species-id-dim" type="text" value="species_id" label="Species ID Output Dimension" help="Name of the LAS extra dimension used for predicted species IDs."/> |
Contributor
Author
|
It's funny because previously it was 35 lines, I tested it locally and it resulted in 25 lines, I was confused because I haven't changed anything fundamentally and apparently local vs remote tests differ somehow... :) cheers |
bgruening
approved these changes
Apr 7, 2026
Owner
Is this still the case? If so its concerning and probably a bug in your code. A container should exactly avoid that. Are some locale settings involved that you read? Some sorting that might be different from C local or UTF-8? |
bgruening
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FOR CONTRIBUTOR:
There are two labels that allow to ignore specific (false positive) tool linter errors:
skip-version-check: Use it if only a subset of the tools has been updated in a suite.skip-url-check: Use it if github CI sees 403 errors, but the URLs work.