Skip to content

Update 3Dtrees: Detailview to v1.1.1#1831

Open
kgerb wants to merge 4 commits intobgruening:masterfrom
3dTrees-earth:update_detailview_v1_1_1
Open

Update 3Dtrees: Detailview to v1.1.1#1831
kgerb wants to merge 4 commits intobgruening:masterfrom
3dTrees-earth:update_detailview_v1_1_1

Conversation

@kgerb
Copy link
Copy Markdown
Contributor

@kgerb kgerb commented Apr 7, 2026

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

There are two labels that allow to ignore specific (false positive) tool linter errors:

  • skip-version-check: Use it if only a subset of the tools has been updated in a suite.
  • skip-url-check: Use it if github CI sees 403 errors, but the URLs work.

Comment thread tools/3dtrees_detailview/detailview.xml Outdated
<token name="@TOOL_VERSION@">1.1.0</token>
<token name="@VERSION_SUFFIX@">0</token>
<token name="@TOOL_VERSION@">1.1.1</token>
<token name="@VERSION_SUFFIX@">1</token>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<token name="@VERSION_SUFFIX@">1</token>
<token name="@VERSION_SUFFIX@">0</token>

Comment thread tools/3dtrees_detailview/detailview.xml Outdated
<requirements>
<container type="docker">ghcr.io/3dtrees-earth/3dtrees_detailview:@TOOL_VERSION@</container>
<!-- <container type="docker">ghcr.io/3dtrees-earth/3dtrees_detailview:@TOOL_VERSION@</container> -->
<container type="docker">docker.io/library/3dtrees-tool-3dtrees_detailview</container>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a version here missing?

Comment thread tools/3dtrees_detailview/detailview.xml Outdated
<option value="/app/model_europe_v1" selected="true">Europe</option>
<option value="/app/model_global_v1">Global</option>
</param>
<param argument="--output-species-id-dim" type="text" value="species_id" label="Species ID Output Dimension" help="Name of the LAS extra dimension used for predicted species IDs."/>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validators?

@kgerb
Copy link
Copy Markdown
Contributor Author

kgerb commented Apr 7, 2026

It's funny because previously it was 35 lines, I tested it locally and it resulted in 25 lines, I was confused because I haven't changed anything fundamentally and apparently local vs remote tests differ somehow... :) cheers

@bgruening
Copy link
Copy Markdown
Owner

It's funny because previously it was 35 lines, I tested it locally and it resulted in 25 lines, I was confused because I haven't changed anything fundamentally and apparently local vs remote tests differ somehow... :) cheers

Is this still the case? If so its concerning and probably a bug in your code. A container should exactly avoid that. Are some locale settings involved that you read? Some sorting that might be different from C local or UTF-8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants