Remove deprecated generate_view_layouts function

[tauanbinato]

Objective

• Fixes Remove bevy_pbr::generate_view_layouts #17537
• The generate_view_layouts function was deprecated in deprecated generate_view_layouts in favor of layout_entries (#17537) #17714 (0.19.0) in favor of layout_entries. It has no internal callers and can now be fully removed.

Solution

• Remove the deprecated generate_view_layouts function from bevy_pbr::render::mesh_view_bindings
• Update the doc comment on MeshPipelineViewLayoutKey to reference layout_entries instead of the removed function

Testing

• cargo check -p bevy_pbr passes cleanly
• No other references to generate_view_layouts exist in the codebase

Migration Guide

• generate_view_layouts has been removed. Use layout_entries instead, as indicated by the deprecation notice added in 0.19.0.

[ChristopherBiscardi]

0.19 hasn't been released yet, so this should not be removed until the deprecation can go out for users to see

[tauanbinato]

0.19 hasn't been released yet, so this should not be removed until the deprecation can go out for users to see

No problem, should I close the pr? Thanks

[ChristopherBiscardi]

I'll leave that up to you. From what I know, I don't see this being merged until at least 0.19's release candidate has started, and I'm not sure when the deprecation is intended to be finalized with a removal. Usually its at least one version. We could probably do all the 0.19 deprecation removals once 0.20's development cycle kicks off.

So if you leave it open it'll be open for a couple weeks at least.

[alice-i-cecile]

We'll get rid of all of the deprecations in one pass later.