Skip to content

Windows paths use backspace when you use the code node js pathmodules#245

Open
ChaseWhite3 wants to merge 2 commits intobenhoIIand:masterfrom
ChaseWhite3:master
Open

Windows paths use backspace when you use the code node js pathmodules#245
ChaseWhite3 wants to merge 2 commits intobenhoIIand:masterfrom
ChaseWhite3:master

Conversation

@ChaseWhite3
Copy link
Copy Markdown

Without this line the depth is not correct on windows

AzureAD\ChaseWhite added 2 commits October 8, 2018 10:21
Copy link
Copy Markdown

@pankaj-arunsingh pankaj-arunsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good windows path fix.

@B3none
Copy link
Copy Markdown

B3none commented Mar 25, 2019

Perhaps fix the spacing:

if (process.platform === "win32") {
    fileDepth = relativeFileDir.split('\\').length;
} else {
    fileDepth = relativeFileDir.split('/').length;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants