Draft
Conversation
Mention: it might pass invalid files, this is, for now, a simple implementation that just checks if the right namespace exists. Very possible to migrate to something more robust in the future
…eiDurlea/beman-tidy into origin/andreidurlea-issue44
Member
Author
|
@neatudarius Could you take a look at this when free? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#44
Mention: The current
check()functionality only checks if the namespace exists, and passes files which might have code outside the namespace. Will be implementing the full, robust, check, if needed. Left a TODO here.