-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update poetry command #6204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update poetry command #6204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `CONTRIBUTING.rst:125` </location>
<code_context>
::
- $ poetry shell
+ $ poetry env activate
You should see ``(beets-py3.10)`` prefix in your shell prompt. Now you can run
</code_context>
<issue_to_address>
**issue:** Re-check whether `poetry env activate` matches the described behavior of activating the virtual environment and changing the prompt.
This command is described as activating the virtualenv and changing your prompt to show `(beets-py3.10)`. That behavior usually matches `poetry shell`; `poetry env activate` often only prints an activation command instead of starting a new shell. Please verify the behavior with the Poetry version you support and either restore `poetry shell` or adjust the explanation so it matches what actually happens.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| :: | ||
|
|
||
| $ poetry shell | ||
| $ poetry env activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Re-check whether poetry env activate matches the described behavior of activating the virtual environment and changing the prompt.
This command is described as activating the virtualenv and changing your prompt to show (beets-py3.10). That behavior usually matches poetry shell; poetry env activate often only prints an activation command instead of starting a new shell. Please verify the behavior with the Poetry version you support and either restore poetry shell or adjust the explanation so it matches what actually happens.
JOJ0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome back again @Serene-Arc 👋 👍
sorcery-ai has a point. we mention that the prompt changes which doesn't with poetry env activate.
there is other commands for showing that info ar adjusting one's prompt manuyll poetry env info for example. We could add that or we just link to the poetry docs which I find better actually. (we might do that already, didn't check)
| $ poetry shell | ||
| $ poetry env activate | ||
|
|
||
| You should see ``(beets-py3.10)`` prefix in your shell prompt. Now you can run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| You should see ``(beets-py3.10)`` prefix in your shell prompt. Now you can run | |
| Now you can run |
|
|
||
| :: | ||
|
|
||
| $ (beets-py3.10) pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| $ pytest |
I was getting my development environment set up so I could start contributing code again (yay!) when I noticed that the docs are out of date.
poetry shellis no longer part of the core poetry tool, but a plugin. Usingpoetry env activateis given as a replacement. This just updates the docs to reflect that. I also added a shortcut so people could understand how to install all the extras, since that's pretty necessary for developers.docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)