Handle error messages from services.#102
Open
mohsin wants to merge 1 commit intobeaulebens:trunkfrom
mohsin:develop
Open
Handle error messages from services.#102mohsin wants to merge 1 commit intobeaulebens:trunkfrom mohsin:develop
mohsin wants to merge 1 commit intobeaulebens:trunkfrom
mohsin:develop
Conversation
* Displays any errors if the error parameter is set. * Allows services to handle their own error messages via a keyring_handle_error_SERVICENAME filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #101.
Details about the code in PR:
redirect_incoming_verify) to avoid it getting stuck in a redirect loop as that redirect handling code will keep getting triggered as long as error exists in the URL.get_error_messageshandles only 2 error codes since those were the ones I was able to reproduce (firstly in the issue I created and again during testing--the 1004 happens when user cancels, the 1006 one happens when either user cancels or the client secret is invalid ). I couldn't find any documentation that lists all the possible error codes (perhaps other APIs do and those could be added by other contributors).