Conversation
jinidev
approved these changes
Apr 24, 2026
elvinasv
reviewed
Apr 24, 2026
Member
elvinasv
left a comment
elvinasv
left a comment
There was a problem hiding this comment.
I see that the x-id-oidc-signedin controls the initial state as expected (tested locally, using request header override), however we still have a layout shift on the homepage.
I think this happens due to the default properties within AccountPromotionalBanner.
AccountPromotionalBanner
| ); | ||
| const isSignedIn = | ||
| isIdctaAvailable && | ||
| Boolean(initialConfig?.initialIsSignedIn || clientSignedInState); |
Member
There was a problem hiding this comment.
I'm wondering if we should still keep the client side fallback?
e.g. if for some reason the x-id-oidc-signedi hint header is missing, it would disable IDCTA/UAS functionality.
WDYT? cc @jinidev
|
|
||
| const cookieHeader = ctx.req?.headers?.cookie; | ||
| const idctaResult = await getIdctaConfig(toggles, service, cookieHeader); | ||
| const signedInHeader = ctx.req?.headers?.['x-id-oidc-signedin'] as |
Member
There was a problem hiding this comment.
Minor: Should we pass the ctx.req?.headers as requestHeaders to the getIdctaConfig? Then we could handle it properly without type casting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2388
Summary
Removes all server-side and shared code that checked the
ckns_idorckns_atkncookies to determine sign-in state. Now, sign-in state is determined during SSR, solely by thex-id-oidc-signedinheader sent by Belfrage.Code changes
ckns_idandckns_atkncookies for SSR sign-in state detection in:src/app/contexts/AccountContext/index.tsx(no more cookie checks, only usesinitialIsSignedInfrom SSR)src/app/models/types/account.ts(removedidentity.idSignedInCookieNamefromIdctaConfig)identityfieldsrc/app/lib/idcta/getIdctaConfig/index.test.tsTesting
yarn test(all tests should pass)x-id-oidc-signedinheader, not cookiesSave Articlebutton,Log invsYour Accountheader button) matches those of signed-in/signed-out states with varying request headers present (x-id-oidc-signedin: 1/0)Useful Links