Add --rust-target to bindgen invocation#3955
Open
UebelAndre wants to merge 3 commits intobazelbuild:mainfrom
Open
Add --rust-target to bindgen invocation#3955UebelAndre wants to merge 3 commits intobazelbuild:mainfrom
--rust-target to bindgen invocation#3955UebelAndre wants to merge 3 commits intobazelbuild:mainfrom
Conversation
UebelAndre
commented
Apr 8, 2026
| user_flags = [f.split("=")[0] for f in ctx.attr.bindgen_flags] | ||
|
|
||
| # Ignore `nightly` or `beta` versions. | ||
| if rust_toolchain.version and rust_toolchain.version[0].isdigit(): |
Collaborator
Author
There was a problem hiding this comment.
This might suggest that rust_toolchain also gets a channel and iso_date attribute to match the repositor yrule interface and make this data more accessible. Even nightly and beta versions have an associated semver version that could be used in rust_toolchain.version
Collaborator
There was a problem hiding this comment.
+1, I think that would make sense
Collaborator
Author
There was a problem hiding this comment.
I pushed a commit that adds iso_date and channel and added a mapping of iso_date -> version so even nightly toolchains have a registered version.
Collaborator
Author
There was a problem hiding this comment.
I've also cut a separate PR for that: #3957
krasimirgg
reviewed
Apr 9, 2026
| user_flags = [f.split("=")[0] for f in ctx.attr.bindgen_flags] | ||
|
|
||
| # Ignore `nightly` or `beta` versions. | ||
| if rust_toolchain.version and rust_toolchain.version[0].isdigit(): |
Collaborator
There was a problem hiding this comment.
+1, I think that would make sense
|
|
||
| # Ignore `nightly` or `beta` versions. | ||
| if rust_toolchain.version and rust_toolchain.version[0].isdigit(): | ||
| # Pass `--rust-target` so bidgen knows the actual toolchain version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.