-
-
Notifications
You must be signed in to change notification settings - Fork 555
Fix examples with Bazel@HEAD #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Regarding BazelCI error: I can't reproduce the error, It passes locally for me. |
|
Did you try in |
I tried it now and it still passes, hmm |
|
As an aside, does anyone know why the CI badge on https://github.com/bazelbuild/examples is red even though the main branch is consistently green? |
I guess https://buildkite.com/bazel/bazel-bazel-examples/settings/badges explains it:
Which is the better signal for this repo? |
|
I didn't manage to reproduce the error but I figured out that
Bazel 9 potentially has stricter input validation for action execution?? Could be that some additional validation is added when it prepares the sandbox or inputs for compilation. Then it would encounter this broken symlink and throw an IOException because the file type (broken symlink) is invalid/unsupported in that context. |
meteorcloudy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! \o/
|
/cc @tjgq probably knows more about the symlink stuff. |
This PR fixes multiple errors from the Downstream:
name 'proto_library' is not defined) - Fix is removingtoolchains_protocsince it was overriding an incompatible version of toolchain.incompatible_use_toolchain_transition- Seemed to be fixed with upgrade of toolchains_llvm.Also, updated links for documentation which were not working.