Skip to content

add rules_pkg 1.2.0#6894

Merged
fmeum merged 3 commits intobazelbuild:mainfrom
rickeylev:rules.pkg.1.2
Dec 20, 2025
Merged

add rules_pkg 1.2.0#6894
fmeum merged 3 commits intobazelbuild:mainfrom
rickeylev:rules.pkg.1.2

Conversation

@rickeylev
Copy link
Contributor

This is a manual release for rules_pkg 1.2.0. This version was tagged and github archive
created, but that was weeks ago and a bzlmod module update hasn't been published.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_pkg) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 1.2.0 of the rules_pkg module. The presubmit.yml and source.json files look good. However, there is a critical issue in MODULE.bazel related to the use of a dev-dependency module extension, which contradicts the guidelines for strict decoupling. The use_repo call for a repo generated by a dev-only extension will break downstream users. I've provided comments with suggestions to fix this by removing the use_repo call and using the canonical repository name instead, aligning with the rule for dev_dependency tool dependencies.

@rickeylev
Copy link
Contributor Author

weird ci error:

(04:47:13) WARNING: Download from file:/workdir/modules/rules_pkg/1.2.0/MODULE.bazel failed: class com.google.devtools.build.lib.vfs.FileAccessException /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/2372b47f32c8a35ea2e7fe6f145cda46/external/rules_pkg~/MODULE.bazel (Permission denied)

Appears to be bazel 7 only. bazel 8 is ok. Looking at rules_pkg, i think it's still testing with bazel 7 ("latest-1").

Should we just remove bazel 7 from the presubmit?

@fmeum
Copy link
Contributor

fmeum commented Dec 20, 2025

Presumably that's because Bazel 7 has not received this fix yet: bazelbuild/bazel#27446

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 20, 2025
fmeum
fmeum previously approved these changes Dec 20, 2025
@fmeum fmeum enabled auto-merge (squash) December 20, 2025 07:46
auto-merge was automatically disabled December 20, 2025 17:51

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed fmeum’s stale review December 20, 2025 17:51

Require module maintainers' approval for newly pushed changes.

@rickeylev
Copy link
Contributor Author

@bazelbuild/bcr-maintainers PTAL -- reapproval needed after merging to head

@fmeum fmeum merged commit 64f707a into bazelbuild:main Dec 20, 2025
16 checks passed
@rickeylev rickeylev deleted the rules.pkg.1.2 branch December 20, 2025 23:54
@aiuto
Copy link
Contributor

aiuto commented Dec 21, 2025

Thanks for pushing this out. I've been futzing around with the push to BCR workflow, but it keeps failing on node not being found.

@rickeylev
Copy link
Contributor Author

yw.

futzing with bcr workflow

In case it's helpful, here's rules_python's setup for the BCR workflow: https://github.com/bazel-contrib/rules_python/blob/main/.github/workflows/publish.yml

(I set up the publish-to-bcr part as a separate job so that it can be retriggered manually if need be, so it's a bit more convoluted of a setup)

I think under the hood it uses ubuntu-latest (2204?). I seen various weird errors using older ubuntu images over the last 6 months that updating ubuntu fixed. rules_python is in the bazel-contrib org instead of bazelbuild, though, IDK if that matters.

@tonyaiuto
Copy link

I finally got it to work. bazelbuild/rules_pkg#998 , but blocked on bazelbuild/rules_pkg#1000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants