Conversation
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_pkg) have been updated in this PR. |
There was a problem hiding this comment.
Code Review
This pull request adds version 1.2.0 of the rules_pkg module. The presubmit.yml and source.json files look good. However, there is a critical issue in MODULE.bazel related to the use of a dev-dependency module extension, which contradicts the guidelines for strict decoupling. The use_repo call for a repo generated by a dev-only extension will break downstream users. I've provided comments with suggestions to fix this by removing the use_repo call and using the canonical repository name instead, aligning with the rule for dev_dependency tool dependencies.
9509745 to
9b42098
Compare
|
weird ci error: Appears to be bazel 7 only. bazel 8 is ok. Looking at rules_pkg, i think it's still testing with bazel 7 ("latest-1"). Should we just remove bazel 7 from the presubmit? |
|
Presumably that's because Bazel 7 has not received this fix yet: bazelbuild/bazel#27446 |
Head branch was pushed to by a user without write access
Require module maintainers' approval for newly pushed changes.
47f8e36 to
fda6531
Compare
…gistry into rules.pkg.1.2
|
@bazelbuild/bcr-maintainers PTAL -- reapproval needed after merging to head |
|
Thanks for pushing this out. I've been futzing around with the push to BCR workflow, but it keeps failing on node not being found. |
|
yw.
In case it's helpful, here's rules_python's setup for the BCR workflow: https://github.com/bazel-contrib/rules_python/blob/main/.github/workflows/publish.yml (I set up the publish-to-bcr part as a separate job so that it can be retriggered manually if need be, so it's a bit more convoluted of a setup) I think under the hood it uses ubuntu-latest (2204?). I seen various weird errors using older ubuntu images over the last 6 months that updating ubuntu fixed. rules_python is in the bazel-contrib org instead of bazelbuild, though, IDK if that matters. |
|
I finally got it to work. bazelbuild/rules_pkg#998 , but blocked on bazelbuild/rules_pkg#1000 |
This is a manual release for rules_pkg 1.2.0. This version was tagged and github archive
created, but that was weeks ago and a bzlmod module update hasn't been published.