Skip to content

Refactor VenomAge: fix bugs, add error handling, input validation, an…#1

Open
batukapicioglu wants to merge 1 commit intomainfrom
claude/code-improvement-review-m3ChR
Open

Refactor VenomAge: fix bugs, add error handling, input validation, an…#1
batukapicioglu wants to merge 1 commit intomainfrom
claude/code-improvement-review-m3ChR

Conversation

@batukapicioglu
Copy link
Copy Markdown
Owner

…d UX improvements

  • Fix duplicate if/elif conditions (elif never executed) in inter() and inter1()
  • Fix duplicate netmask condition in ipchan() (second 255.255.255.0 check)
  • Remove unused mac variable in inter1(); fix trailing spaces in MAC list
  • Fix typo "Rondom" -> "Random" in labels and button text
  • Add root permission check at startup with clear error message
  • Add validate_mac() and validate_ip() helper functions with regex
  • Add generate_random_mac() that generates IEEE-compliant random MACs
  • Add get_current_mac() and get_current_ip() to display current values
  • Replace deprecated subprocess.call() with subprocess.run() + return code checks
  • Wrap all subprocess calls in try-except for proper error reporting
  • Replace tk.Tk() destroy/recreate anti-pattern with tk.Toplevel + form.withdraw()
  • Replace Entry fields with ttk.Combobox populated from /sys/class/net/ for interfaces
  • Add confirmation dialogs before applying network changes
  • Show current MAC/IP address on interface selection

…d UX improvements

- Fix duplicate if/elif conditions (elif never executed) in inter() and inter1()
- Fix duplicate netmask condition in ipchan() (second 255.255.255.0 check)
- Remove unused `mac` variable in inter1(); fix trailing spaces in MAC list
- Fix typo "Rondom" -> "Random" in labels and button text
- Add root permission check at startup with clear error message
- Add validate_mac() and validate_ip() helper functions with regex
- Add generate_random_mac() that generates IEEE-compliant random MACs
- Add get_current_mac() and get_current_ip() to display current values
- Replace deprecated subprocess.call() with subprocess.run() + return code checks
- Wrap all subprocess calls in try-except for proper error reporting
- Replace tk.Tk() destroy/recreate anti-pattern with tk.Toplevel + form.withdraw()
- Replace Entry fields with ttk.Combobox populated from /sys/class/net/ for interfaces
- Add confirmation dialogs before applying network changes
- Show current MAC/IP address on interface selection

https://claude.ai/code/session_01UpnSPPaUbbJVuSXB9g4EPL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants