Returning the error message detail(when accepting/creating scrimmage) from backend to frontend #914
Merged
nour-massri merged 2 commits intomainfrom Jan 15, 2025
Merged
Conversation
nour-massri
changed the title
Member
Author
|
closes #908 |
lowtorola
approved these changes
Jan 15, 2025
Contributor
lowtorola
left a comment
lowtorola
left a comment
There was a problem hiding this comment.
Assuming youve tested this it looks great to me! see my comment about the refactored function, that would be a great issue to create 
Comment on lines
+379
to
+388
| } catch (e: unknown) { | ||
| const error = e as ResponseError; | ||
| // Parse the response text as JSON, detail propety contains the error message | ||
| const errorJson = (await error.response.json()) as { | ||
| detail?: string; | ||
| }; | ||
| const errorDetail = | ||
| errorJson.detail ?? "An unexpected error occurred."; | ||
| throw new Error(errorDetail); | ||
| } |
Contributor
There was a problem hiding this comment.
This is great! At some point we need to go through and make this a type-ified function which errors in detail for every frontend mutation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.