Add --no-min-tokens flag to skip min_tokens in requests#25
Merged
JimmyWhitaker merged 1 commit intomainfrom Feb 13, 2026
Merged
Add --no-min-tokens flag to skip min_tokens in requests#25JimmyWhitaker merged 1 commit intomainfrom
JimmyWhitaker merged 1 commit intomainfrom
Conversation
This flag is useful for backends that don't support min_tokens, such as vLLM with speculative decoding enabled. Changes: - Add --no-min-tokens CLI flag in sampling_options - Pass no_min_tokens parameter through to TextSampler - Skip setting min_tokens when no_min_tokens=True Usage: genai-bench benchmark --no-min-tokens ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag is useful for backends that don't support min_tokens, such as vLLM with speculative decoding enabled.
Changes:
Usage:
genai-bench benchmark --no-min-tokens ...
Description
Related Issue
Changes
Correctness Tests
Checklist
git pull origin main)make checkto ensure code is properly formatted and passes all lint checksmake testormake test_changedto verify test coverage (~90% required)Additional Information
Add any other context, screenshots, or information about the PR here.