Add conflict handling for --disable-streaming with async execution engine#23
Open
Add conflict handling for --disable-streaming with async execution engine#23
Conversation
…gine When --disable-streaming is used with --execution-engine=async: - If async-specific parameters (--qps-level, --distribution, --track-network-timing) are present, warn and run async with streaming enabled - If no async-specific parameters, warn and automatically fallback to Locust execution engine This prevents the async runner from being used in unsupported non-streaming mode while preserving access to async-specific features when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
--disable-streamingis used with--execution-engine=async, the async runner cannot function properly since it requires streaming. This PR adds intelligent conflict handling:--qps-level,--distribution,--track-network-timing): Warn the user and run with async execution engine with streaming enabled (overriding--disable-streaming)This preserves access to async-specific features when needed while preventing unsupported configurations.
Changes
genai_bench/cli/cli.pyto detect async-specific parameters and handle conflictstests/cli/test_cli_async.py:Testing
All existing tests pass, plus 3 new test cases added.