Open
Conversation
Previously, any ERROR log (including 404s from wrong model names) would trigger sys.exit(1), causing crash loops when users provided incorrect configuration. Now only CRITICAL logs trigger exit. Recoverable errors like HTTP 404s are logged but the benchmark continues, reporting 0 successful requests which correctly indicates the failure without crashing.
560b53c to
061ade0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sys.exit(1)trigger from ERROR level to CRITICAL level inDelayedRichHandlerProblem
Previously, any ERROR log would trigger
sys.exit(1), causing:Solution
Only exit on CRITICAL logs. Recoverable errors like HTTP 404s are logged but the benchmark continues, reporting 0 successful requests which correctly indicates the failure without crashing.
Test plan
🤖 Generated with Claude Code