Conversation
Replace inline classify and breaking-change jobs with thin callers to centralized reusable workflows in basecamp/.github that separate AI inference from PR mutation into distinct jobs: - infer job: models:read, contents:read (no PR write access) - apply job: pull-requests:write, issues:write (no models access) Ref: HackerOne #3585928
- Add environment: release to sync-skills and aur-publish jobs - Pin all action refs to immutable SHA commits - Fix version comments on cosign-installer and ai-inference Ref: HackerOne #3585928
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR "privilege-separates" the AI labeler workflows by replacing inline classify and breaking jobs with thin callers to centralized reusable workflows in basecamp/.github. It also gates sync-skills and aur-publish behind environment: release approval, and updates version comments on two pinned SHA action references.
Changes:
- Replace inline AI classification and breaking-change detection logic with calls to external reusable workflows (
basecamp/.github) pinned at a SHA - Add
environment: releaseto theaur-publishandsync-skillsjobs, requiring environment approval before secrets are accessible - Update version comments on two SHA-pinned actions in
release.yml(# v3→# v4.0.0for cosign-installer,# v2→# v2.0.7for ai-inference)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
.github/workflows/ai-labeler.yml |
Replaces 185 lines of inline scripted jobs with two thin reusable-workflow caller jobs, and adds (invalid) permissions: blocks on each caller job |
.github/workflows/release.yml |
Adds environment: release to aur-publish and sync-skills jobs; updates version annotations on two SHA-pinned actions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
basecamp/.githubthat separate inference from mutationsync-skillsandaur-publishbehindenvironment: releasecosign-installerv4.0.0,ai-inferencev2.0.7)Privilege separation
models:read,contents:readpull-requests:write,issues:writeEnvironment gates
sync-skillsenvironment: releaserequiredaur-publishenvironment: releaserequiredTest plan
internal/cmd/*.gosync-skillsandaur-publishprompt for environment approval on tag push