Use Copy Elision and Pass-by-value to simplify the code + Many other fixes#278
Merged
ayushsharma82 merged 3 commits intoayushsharma82:devfrom Nov 22, 2025
Merged
Use Copy Elision and Pass-by-value to simplify the code + Many other fixes#278ayushsharma82 merged 3 commits intoayushsharma82:devfrom
ayushsharma82 merged 3 commits intoayushsharma82:devfrom
Conversation
Contributor
|
This PR is marked as stale because it has been open 45 days with no activity. You can remove stale label or comment if this PR is still valid. |
... because it is possible that the user inputs a blank value fr example that is reverted back to the previous one (so no change is recorded)
mathieucarbou
changed the title
Contributor
Author
|
@ayushsharma82 : please merge ;-) |
Owner
|
I'll merge it tomorrow |
ayushsharma82
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://abseil.io/tips/117
Firmware size is about 500 bytes less