Open
Conversation
hazzik
changed the title
hazzik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This refactor removes the outdated Tendermint dependency, which was previously used only for logging. The changes maintain source compatibility with the previous implementation.
The
Setupfunction now accepts not only thetmlog.Loggerinterface but also any interface or struct with a compatible structure.A direct copy of
tmlog.Loggerwas not possible because it is self-referential, and Go does not support covariant return types. To address this, I used generics and split the interfaces to maintain compile-time type safety.Todos
Steps to Test
Expected Behaviour
Other Notes