Fix handling of empty SSEKMSKeyId parameter#33
Open
asafonov303 wants to merge 1 commit intoawslabs:mainfrom
Open
Fix handling of empty SSEKMSKeyId parameter#33asafonov303 wants to merge 1 commit intoawslabs:mainfrom
asafonov303 wants to merge 1 commit intoawslabs:mainfrom
Conversation
Ensure uploads of files smaller than 5MB succeed when no KMS key is specified. In github.com/aws/aws-sdk-go-v2/service/s3 (c *Client) PutObject handles SSEKMSKeyId differently across versions: - v1.52.0 accepts a pointer to an empty string without issue - v1.91.1 requires nil; otherwise S3 responds with HTTP 400: "InvalidArgument: Server Side Encryption with AWS KMS managed key requires HTTP header x-amz-server-side-encryption : aws:kms" Update code to pass nil when SSEKMSKeyId is not specified. Apply the same change to (c *Client) CreateMultipartUpload, even though it does not currently cause errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure uploads of files smaller than 5MB succeed when no KMS key is specified.
In github.com/aws/aws-sdk-go-v2/service/s3 (c *Client) PutObject handles SSEKMSKeyId differently across versions:
Update code to pass nil when SSEKMSKeyId is not specified.
Apply the same change to (c *Client) CreateMultipartUpload, even though it does not currently cause errors.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.