Fix producer-consumer pattern in concatObjAndHeader#28
Open
ppulc wants to merge 1 commit intoawslabs:mainfrom
Open
Fix producer-consumer pattern in concatObjAndHeader#28ppulc wants to merge 1 commit intoawslabs:mainfrom
ppulc wants to merge 1 commit intoawslabs:mainfrom
Conversation
The whole producer loop needs to be enclosed in a goroutine to allow the main thread to start consuming the messages from the queue. Otherwise the whole waitgroup was consumed without any message being read from the queue and writes were blocked as well because the queue is unbuffered...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole producer loop needs to be enclosed in a goroutine to allow the main thread to start consuming the messages from the queue.
Otherwise the whole waitgroup was consumed without any message being read from the queue and writes were blocked as well because the queue is unbuffered...
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.