-
Notifications
You must be signed in to change notification settings - Fork 574
Adding structured logging helper #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+615
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
+ Coverage 73.67% 74.94% +1.27%
==========================================
Files 35 36 +1
Lines 1341 1401 +60
==========================================
+ Hits 988 1050 +62
+ Misses 277 273 -4
- Partials 76 78 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bmoffatt
requested changes
Jan 14, 2026
- Rename Handler() to LogHandler() - Rename LogFormatName/LogLevelName to LogFormat/LogLevel - Use functional options pattern with WithFields() - Use Field functions (FieldFunctionARN, FieldTenantID) for immutability - Add example tests in separate file with go1.21 build tag
bmoffatt
reviewed
Jan 14, 2026
bmoffatt
reviewed
Jan 14, 2026
bmoffatt
reviewed
Jan 14, 2026
bmoffatt
reviewed
Jan 14, 2026
bmoffatt
previously approved these changes
Jan 15, 2026
Collaborator
bmoffatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
trivenay
reviewed
Jan 15, 2026
37549f7 to
32cebc3
Compare
bmoffatt
approved these changes
Jan 15, 2026
trivenay
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding helper for structured logging so users can log as JSON with slog easier than before.
LogFormatNameandLogLevelNameare added tocontext.goas well so it can be easier and cleaner to setup a structured logger as well.Tests:
Added tests for
logger.goBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.