fix flaky test TestRuntimeAPILoopWithConcurrency#606
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
- Coverage 73.30% 71.22% -2.08%
==========================================
Files 26 35 +9
Lines 1487 1630 +143
==========================================
+ Hits 1090 1161 +71
- Misses 324 395 +71
- Partials 73 74 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bmoffatt
approved these changes
Dec 11, 2025
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
The
TestRuntimeAPILoopWithConcurrencyfails occasionally.It is because the "END THE TEST!" signal is canceling out the normal GET request.
I've made it so that the "END THE TEST!" signal is sent only after other requests have finished successfully.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.